From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 2 Sep 2019 14:38:50 +0000 (+0300)
Subject: platform/x86: asus-wmi: Fix condition in charge_threshold_store()
X-Git-Tag: v5.4-rc1~166^2~24
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=07779c33a7282366f979e384de263e42aa422ada;p=users%2Fjedix%2Flinux-maple.git

platform/x86: asus-wmi: Fix condition in charge_threshold_store()

This error handling is reversed so we return early.

Fixes: 84d8e80b0a36 ("platform/x86: asus-wmi: Refactor charge_threshold_store()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 14467748b343..848b23764fc3 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -2068,7 +2068,7 @@ static ssize_t charge_threshold_store(struct device *dev,
 		return -EINVAL;
 
 	ret = asus_wmi_set_devstate(ASUS_WMI_CHARGE_THRESHOLD, value, &rv);
-	if (!ret)
+	if (ret)
 		return ret;
 
 	if (rv != 1)