From: Paul E. McKenney Date: Tue, 25 May 2021 18:28:40 +0000 (-0700) Subject: rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=05f418f105e5b6e2f6b4213e95e08b4db0b4dbf8;p=users%2Fjedix%2Flinux-maple.git rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader() Invoking trc_del_holdout() from within trc_wait_for_one_reader() is only a performance optimization because the RCU Tasks Trace grace-period kthread will eventually do this within check_all_holdout_tasks_trace(). But it is not a particularly important performance optimization because it only applies to the grace-period kthread, of which there is but one. This commit therefore removes this invocation of trc_del_holdout() in favor of the one in check_all_holdout_tasks_trace() in the grace-period kthread. Reported-by: "Xu, Yanfei" Signed-off-by: Paul E. McKenney --- diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 8b25551d10dbc..1cece5e9be9a9 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -986,7 +986,6 @@ static void trc_wait_for_one_reader(struct task_struct *t, // The current task had better be in a quiescent state. if (t == current) { t->trc_reader_checked = true; - trc_del_holdout(t); WARN_ON_ONCE(READ_ONCE(t->trc_reader_nesting)); return; }