From: Jeff Garzik <jeff@garzik.org>
Date: Thu, 17 Dec 2009 06:23:16 +0000 (-0500)
Subject: sata_mv: remove pointless NULL test
X-Git-Tag: v2.6.33-rc2~45^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0535f2bc170bc0779ac471faff39f633ca19ab59;p=linux.git

sata_mv: remove pointless NULL test

Remove !ap test, where ap is guaranteed not-NULL.  Found by way of automated
bug report from Alexander Strakh via "Linux Device Drivers Verification
Project (Svace Detector)"

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 73768195ccc2..df8ee325d3ca 100755
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -2781,7 +2781,7 @@ static void mv_port_intr(struct ata_port *ap, u32 port_cause)
 	struct mv_port_priv *pp;
 	int edma_was_enabled;
 
-	if (!ap || (ap->flags & ATA_FLAG_DISABLED)) {
+	if (ap->flags & ATA_FLAG_DISABLED) {
 		mv_unexpected_intr(ap, 0);
 		return;
 	}