From: Oleg Nesterov <oleg@redhat.com>
Date: Wed, 26 May 2010 21:43:05 +0000 (-0700)
Subject: call_usermodehelper: UMH_WAIT_EXEC ignores kernel_thread() failure
X-Git-Tag: v2.6.35-rc1~176
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=04b1c384fbc4e0209e5c1affb67050886376d44b;p=users%2Fwilly%2Fxarray.git

call_usermodehelper: UMH_WAIT_EXEC ignores kernel_thread() failure

UMH_WAIT_EXEC should report the error if kernel_thread() fails, like
UMH_WAIT_PROC does.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/kernel/kmod.c b/kernel/kmod.c
index ad9f2edebd67..6e9b19667a8d 100644
--- a/kernel/kmod.c
+++ b/kernel/kmod.c
@@ -235,10 +235,10 @@ static void __call_usermodehelper(struct work_struct *work)
 	case UMH_WAIT_PROC:
 		if (pid > 0)
 			break;
-		sub_info->retval = pid;
 		/* FALLTHROUGH */
-
 	case UMH_WAIT_EXEC:
+		if (pid < 0)
+			sub_info->retval = pid;
 		complete(sub_info->complete);
 	}
 }