From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 15 Jun 2021 07:39:52 +0000 (+0100)
Subject: afs: Fix an IS_ERR() vs NULL check
X-Git-Tag: v5.4.128~86
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0498165c6fec26fb1832cea2f45e05913efacf4b;p=users%2Fdwmw2%2Flinux.git

afs: Fix an IS_ERR() vs NULL check

[ Upstream commit a33d62662d275cee22888fa7760fe09d5b9cd1f9 ]

The proc_symlink() function returns NULL on error, it doesn't return
error pointers.

Fixes: 5b86d4ff5dce ("afs: Implement network namespacing")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
Link: https://lore.kernel.org/r/YLjMRKX40pTrJvgf@mwanda/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/fs/afs/main.c b/fs/afs/main.c
index 5cd26af2464c9..d129a1a49616b 100644
--- a/fs/afs/main.c
+++ b/fs/afs/main.c
@@ -196,8 +196,8 @@ static int __init afs_init(void)
 		goto error_fs;
 
 	afs_proc_symlink = proc_symlink("fs/afs", NULL, "../self/net/afs");
-	if (IS_ERR(afs_proc_symlink)) {
-		ret = PTR_ERR(afs_proc_symlink);
+	if (!afs_proc_symlink) {
+		ret = -ENOMEM;
 		goto error_proc;
 	}