From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 24 Jan 2012 21:59:31 +0000 (+0000)
Subject: bnx2x: unlock before returning an error
X-Git-Tag: v2.6.39-400.9.0~423^2~19^2~11^2~503
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0383421c44b5c5e02cf9ed7e38547c2e0802f678;p=users%2Fjedix%2Flinux-maple.git

bnx2x: unlock before returning an error

We introduced a new return here but forgot to drop the lock.

(cherry picked from commit a44acd551467d78a26bfa76ea348225575830efc)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
---

diff --git a/drivers/net/bnx2x/bnx2x_sp.c b/drivers/net/bnx2x/bnx2x_sp.c
index 13c5f26a35fe..af28c30b411c 100644
--- a/drivers/net/bnx2x/bnx2x_sp.c
+++ b/drivers/net/bnx2x/bnx2x_sp.c
@@ -1837,6 +1837,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,
 			rc = exeq->remove(bp, exeq->owner, exeq_pos);
 			if (rc) {
 				BNX2X_ERR("Failed to remove command\n");
+				spin_unlock_bh(&exeq->lock);
 				return rc;
 			}
 			list_del(&exeq_pos->link);