From: Michael Straube Date: Tue, 29 Mar 2022 10:37:54 +0000 (+0200) Subject: staging: r8188eu: refactor rtw_inc_and_chk_continual_urb_error() X-Git-Tag: howlett/maple/20220722_2~355^2~335 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0166ffdc89bf4d5f50852eb4bc86bbd18cffd4f9;p=users%2Fjedix%2Flinux-maple.git staging: r8188eu: refactor rtw_inc_and_chk_continual_urb_error() Refactor rtw_inc_and_chk_continual_urb_error(). Return directly instead of using a return variable and initialize the variable 'value' at declaration. This shortens the code and improves readability. Signed-off-by: Michael Straube Link: https://lore.kernel.org/r/20220329103756.6740-3-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8188eu/include/usb_ops.h index 3416c8baceb6..cfcf6f84d2cf 100644 --- a/drivers/staging/r8188eu/include/usb_ops.h +++ b/drivers/staging/r8188eu/include/usb_ops.h @@ -27,13 +27,12 @@ */ static inline int rtw_inc_and_chk_continual_urb_error(struct dvobj_priv *dvobj) { - int ret = false; - int value; - value = atomic_inc_return(&dvobj->continual_urb_error); + int value = atomic_inc_return(&dvobj->continual_urb_error); + if (value > MAX_CONTINUAL_URB_ERR) - ret = true; + return true; - return ret; + return false; } /*