]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path
authorColin Ian King <colin.king@canonical.com>
Tue, 10 Apr 2018 12:33:12 +0000 (13:33 +0100)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Wed, 11 Apr 2018 06:37:58 +0000 (14:37 +0800)
The error exit path when a duplicate is found does not kfree and cmd_entry
struct and hence there is a small memory leak.  Fix this by kfree'ing it.

Detected by CoverityScan, CID#1370198 ("Resource Leak")

Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
drivers/gpu/drm/i915/gvt/cmd_parser.c

index db6b94dda5dfaede1ebb97cc21b17ea301fdd275..6bd56ecda31ceb0ed82c80a17e5498b20d6f0a02 100644 (file)
@@ -2863,6 +2863,7 @@ static int init_cmd_table(struct intel_gvt *gvt)
                if (info) {
                        gvt_err("%s %s duplicated\n", e->info->name,
                                        info->name);
+                       kfree(e);
                        return -EEXIST;
                }