greybus: fix gb_manifest_parse() successful return path

Even if we successfully parse a manifest we are returning
failure. Instead, we now proudly proclaim success.

Signed-off-by: Matt Porter <mporter@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

diff --git a/drivers/staging/greybus/manifest.c b/drivers/staging/greybus/manifest.c
index 43ece7403c775c16099b8c1c8d95349e764fe7c9..09fcde9dd7ce115014e612a3e1efc5c3e84f42c8 100644 (file)
--- a/drivers/staging/greybus/manifest.c
+++ b/drivers/staging/greybus/manifest.c
@@ -364,6 +364,7 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size)
                if (desc_size <= 0) {
                        if (!desc_size)
                                pr_err("zero-sized manifest descriptor\n");
+                       result = false;
                        goto out;
                }
                desc = (struct greybus_descriptor *)((char *)desc + desc_size);
@@ -379,6 +380,7 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size)
        if (found != 1) {
                pr_err("manifest must have 1 module descriptor (%u found)\n",
                        found);
+               result = false;
                goto out;
        }
 
@@ -394,5 +396,5 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size)
 out:
        release_manifest_descriptors();
 
-       return false;
+       return result;
 }