]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/bridge: lt9611: Fix an error handling path in lt9611_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 29 Jan 2022 15:06:24 +0000 (16:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 11:58:00 +0000 (13:58 +0200)
[ Upstream commit 9987151a90567785beebcbd5c8ac58d05f254137 ]

If lt9611_audio_init() fails, some resources still need to be released
before returning an error code.

Add the missing goto the error handling path.

Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/9c20eb74d42f6d4128e58e3e46aa320482472b77.1643468761.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/lontium-lt9611.c

index dafb1b47c15fb2d7d6b774b45c66d5e8041280b7..00597eb54661f79781c4b35642c00db82608e118 100644 (file)
@@ -1164,7 +1164,11 @@ static int lt9611_probe(struct i2c_client *client,
 
        lt9611_enable_hpd_interrupts(lt9611);
 
-       return lt9611_audio_init(dev, lt9611);
+       ret = lt9611_audio_init(dev, lt9611);
+       if (ret)
+               goto err_remove_bridge;
+
+       return 0;
 
 err_remove_bridge:
        drm_bridge_remove(&lt9611->bridge);