]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
accel/habanalabs: move ioctl error print to debug level
authorOded Gabbay <ogabbay@kernel.org>
Thu, 18 May 2023 07:59:38 +0000 (10:59 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Thu, 8 Jun 2023 09:35:56 +0000 (12:35 +0300)
We don't want to allow users to spam the kernel log and sending
ioctls with bad opcodes is a sure way to do it.

Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Ofir Bitton <obitton@habana.ai>
drivers/accel/habanalabs/common/habanalabs_ioctl.c

index 9a8be9395fb28d7c8b386ead4eb14b9d20193d05..6a45a92344e9bde61baeed7fddfce295fb4b0086 100644 (file)
@@ -1195,7 +1195,7 @@ static long _hl_ioctl(struct file *filep, unsigned int cmd, unsigned long arg,
 
 out_err:
        if (retcode)
-               dev_dbg(dev, "error in ioctl: pid=%d, cmd=0x%02x, nr=0x%02x\n",
+               dev_dbg_ratelimited(dev, "error in ioctl: pid=%d, cmd=0x%02x, nr=0x%02x\n",
                          task_pid_nr(current), cmd, nr);
 
        if (kdata != stack_kdata)
@@ -1219,7 +1219,7 @@ long hl_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
        if ((nr >= HL_COMMAND_START) && (nr < HL_COMMAND_END)) {
                ioctl = &hl_ioctls[nr];
        } else {
-               dev_err(hdev->dev, "invalid ioctl: pid=%d, nr=0x%02x\n",
+               dev_dbg_ratelimited(hdev->dev, "invalid ioctl: pid=%d, nr=0x%02x\n",
                        task_pid_nr(current), nr);
                return -ENOTTY;
        }
@@ -1242,7 +1242,7 @@ long hl_ioctl_control(struct file *filep, unsigned int cmd, unsigned long arg)
        if (nr == _IOC_NR(HL_IOCTL_INFO)) {
                ioctl = &hl_ioctls_control[nr];
        } else {
-               dev_err(hdev->dev_ctrl, "invalid ioctl: pid=%d, nr=0x%02x\n",
+               dev_dbg_ratelimited(hdev->dev_ctrl, "invalid ioctl: pid=%d, nr=0x%02x\n",
                        task_pid_nr(current), nr);
                return -ENOTTY;
        }