media: s5p-mfc: Fix encoder menu controls initialization

This patch fixes the menu_skip_mask field initialization and
addresses a following issue found by the SVACE static analysis:

* NO_EFFECT.SELF: assignment to self in expression 'cfg.menu_skip_mask = cfg.menu_skip_mask'
  No effect at drivers/media/platform/s5p-mfc/s5p_mfc_enc.c:2083

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index 2a5fd7c42cd50dc7792be186e1611c8d29b3a8fa..0d5d465561becbf587f9aaf3ea84ffbb7fab8d66 100644 (file)
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -2080,7 +2080,7 @@ int s5p_mfc_enc_ctrls_setup(struct s5p_mfc_ctx *ctx)
 
                        if (cfg.type == V4L2_CTRL_TYPE_MENU) {
                                cfg.step = 0;
-                               cfg.menu_skip_mask = cfg.menu_skip_mask;
+                               cfg.menu_skip_mask = controls[i].menu_skip_mask;
                                cfg.qmenu = mfc51_get_menu(cfg.id);
                        } else {
                                cfg.step = controls[i].step;