]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
Fix Memory leak on fail case of mbuffer
authorlakshminarayanand <Lakshmi_Narayanan_Du@dell.com>
Mon, 7 Mar 2016 10:34:11 +0000 (16:04 +0530)
committerlakshminarayanand <Lakshmi_Narayanan_Du@dell.com>
Mon, 7 Mar 2016 10:34:11 +0000 (16:04 +0530)
nvme.c

diff --git a/nvme.c b/nvme.c
index 0344812b4b4e66ae1093ed2929a06d42e339c43f..eb4d87bfb50c68da39b13595201972d820344509 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -2212,8 +2212,10 @@ static int submit_io(int opcode, char *command, const char *desc,
 
        if (cfg.metadata_size) {
                mbuffer = malloc(cfg.metadata_size);
-               if (!mbuffer)
+               if (!mbuffer) {
+                       free(buffer);
                        return ENOMEM;
+               }
        }
 
        if ((opcode & 1) && read(dfd, (void *)buffer, cfg.data_size) < 0) {