fs: avoid inode RCU freeing for pseudo fs

Pseudo filesystems that don't put inode on RCU list or reachable by
rcu-walk dentries do not need to RCU free their inodes.

Signed-off-by: Nick Piggin <npiggin@kernel.dk>

diff --git a/fs/inode.c b/fs/inode.c
index 6751dfe8cc06cb56c6c635b0c0aa57151cc0ea48..da85e56378f3e1d98c241901171e24e83882f189 100644 (file)
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -257,6 +257,12 @@ static struct inode *alloc_inode(struct super_block *sb)
        return inode;
 }
 
+void free_inode_nonrcu(struct inode *inode)
+{
+       kmem_cache_free(inode_cachep, inode);
+}
+EXPORT_SYMBOL(free_inode_nonrcu);
+
 void __destroy_inode(struct inode *inode)
 {
        BUG_ON(inode_has_buffers(inode));

diff --git a/fs/pipe.c b/fs/pipe.c
index 04629f36e3978dc44ec1611994664f157cc9d4f8..ae3592dcc88c32435e74cf9be5a9f7fedaa4fa10 100644 (file)
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -1253,6 +1253,10 @@ out:
        return ret;
 }
 
+static const struct super_operations pipefs_ops = {
+       .destroy_inode = free_inode_nonrcu,
+};
+
 /*
  * pipefs should _never_ be mounted by userland - too much of security hassle,
  * no real gain from having the whole whorehouse mounted. So we don't need
@@ -1262,7 +1266,7 @@ out:
 static struct dentry *pipefs_mount(struct file_system_type *fs_type,
                         int flags, const char *dev_name, void *data)
 {
-       return mount_pseudo(fs_type, "pipe:", NULL, PIPEFS_MAGIC);
+       return mount_pseudo(fs_type, "pipe:", &pipefs_ops, PIPEFS_MAGIC);
 }
 
 static struct file_system_type pipe_fs_type = {

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 1ff4d0a33b25a8942cd0d6417074b608b5b33400..ea202fff44f82a83a2ab93a33ca84e0fa74664b4 100644 (file)
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2233,6 +2233,7 @@ extern void iget_failed(struct inode *);
 extern void end_writeback(struct inode *);
 extern void __destroy_inode(struct inode *);
 extern struct inode *new_inode(struct super_block *);
+extern void free_inode_nonrcu(struct inode *inode);
 extern int should_remove_suid(struct dentry *);
 extern int file_remove_suid(struct file *);
 

diff --git a/include/linux/net.h b/include/linux/net.h
index 06bde4908473da67b664fba51f13aed0c0fa58d2..16faa130088c298fe8540b7fa29d365d0ea579b7 100644 (file)
--- a/include/linux/net.h
+++ b/include/linux/net.h
@@ -120,6 +120,7 @@ enum sock_shutdown_cmd {
 struct socket_wq {
        wait_queue_head_t       wait;
        struct fasync_struct    *fasync_list;
+       struct rcu_head         rcu;
 } ____cacheline_aligned_in_smp;
 
 /**

diff --git a/net/socket.c b/net/socket.c
index 97fff3a4e72f30fb1a96ec095bb02efbfca5c566..817dc92e9ef809b0dc9f32f8d9f368e27946d036 100644 (file)
--- a/net/socket.c
+++ b/net/socket.c
@@ -262,20 +262,21 @@ static struct inode *sock_alloc_inode(struct super_block *sb)
 }
 
 
-static void sock_free_rcu(struct rcu_head *head)
+
+static void wq_free_rcu(struct rcu_head *head)
 {
-       struct inode *inode = container_of(head, struct inode, i_rcu);
-       struct socket_alloc *ei = container_of(inode, struct socket_alloc,
-                                                               vfs_inode);
+       struct socket_wq *wq = container_of(head, struct socket_wq, rcu);
 
-       kfree(ei->socket.wq);
-       INIT_LIST_HEAD(&inode->i_dentry);
-       kmem_cache_free(sock_inode_cachep, ei);
+       kfree(wq);
 }
 
 static void sock_destroy_inode(struct inode *inode)
 {
-       call_rcu(&inode->i_rcu, sock_free_rcu);
+       struct socket_alloc *ei;
+
+       ei = container_of(inode, struct socket_alloc, vfs_inode);
+       call_rcu(&ei->socket.wq->rcu, wq_free_rcu);
+       kmem_cache_free(sock_inode_cachep, ei);
 }
 
 static void init_once(void *foo)