]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme-cli: Increase size of ONTAP namespace path variable
authorSimon Schricker <sschricker@suse.de>
Tue, 16 Apr 2019 13:27:40 +0000 (06:27 -0700)
committerKeith Busch <keith.busch@intel.com>
Wed, 17 Apr 2019 22:43:32 +0000 (16:43 -0600)
nspath's size is ONTAP_NS_PATHLEN and is written to by:

snprintf(nspath, ONTAP_NS_PATHLEN, "%s%s%s%s", ontap_vol,
                        vol_name, "/", ns_name);

Required bytes:

- ontap_vol is a constant char pointer, set to "/vol/", so 5 bytes
- vol_name's size is ONTAP_LABEL_LEN, which is 260, deducting the
  null-byte for termination makes 259 required bytes
- "/" is 1 byte
- ns_name's size is also ONTAP_LABEL_LEN, which is 260, deducting
  the null-byte for termination makes 259 required bytes
- the final null-byte: 1

That makes in total 5 + 259 + 1 + 259 + 1 = 525 required bytes

Signed-off-by: Simon Schricker <sschricker@suse.de>
plugins/netapp/netapp-nvme.c

index 295131131963b8fb357cb3b5e7c63d355af1dbce..aa5a94d9d7cdd178ecf56a627e4ffaf9d4c1e63d 100644 (file)
@@ -35,7 +35,7 @@
 #define ONTAP_C2_LOG_ID                0xC2
 #define ONTAP_C2_LOG_SIZE      4096
 #define ONTAP_LABEL_LEN                260
-#define ONTAP_NS_PATHLEN       520
+#define ONTAP_NS_PATHLEN       525
 
 enum {
        NNORMAL,