]> www.infradead.org Git - nvme.git/commitdiff
nvme-tcp: fix the memleak while create new ctrl failed
authorChunguang.xu <chunguang.xu@shopee.com>
Tue, 3 Dec 2024 03:34:40 +0000 (11:34 +0800)
committerKeith Busch <kbusch@kernel.org>
Wed, 4 Dec 2024 18:15:46 +0000 (10:15 -0800)
Now while we create new ctrl failed, we have not free the
tagset occupied by admin_q, here try to fix it.

Fixes: fd1418de10b9 ("nvme-tcp: avoid open-coding nvme_tcp_teardown_admin_queue()")
Signed-off-by: Chunguang.xu <chunguang.xu@shopee.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/tcp.c

index 3e416af2659f19f6a7377319d45ac368a6dedf38..55abfe5e1d2548936e91c402b06564c514425fdf 100644 (file)
@@ -2278,7 +2278,7 @@ destroy_io:
        }
 destroy_admin:
        nvme_stop_keep_alive(ctrl);
-       nvme_tcp_teardown_admin_queue(ctrl, false);
+       nvme_tcp_teardown_admin_queue(ctrl, new);
        return ret;
 }