]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
scsi: ufs: core: Increase the START STOP UNIT timeout from one to ten seconds
authorBart Van Assche <bvanassche@acm.org>
Wed, 24 May 2023 20:36:19 +0000 (13:36 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 1 Jun 2023 00:35:01 +0000 (20:35 -0400)
One UFS vendor asked to increase the UFS timeout from 1 s to 3 s.  Another
UFS vendor asked to increase the UFS timeout from 1 s to 10 s.  Hence this
patch that increases the UFS timeout to 10 s. This patch can cause the
total timeout to exceed 20 s, the Android shutdown timeout.  This is fine
since the loop around ufshcd_execute_start_stop() exists to deal with unit
attentions and because unit attentions are reported quickly.

Fixes: dcd5b7637c6d ("scsi: ufs: Reduce the START STOP UNIT timeout")
Fixes: 8f2c96420c6e ("scsi: ufs: core: Reduce the power mode change timeout")
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20230524203659.1394307-2-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index 17d7bb875fee8355b796c2bc842a260ce8e44dbf..ff92e53835dfce1cde7739b1aa834d4d088adc68 100644 (file)
@@ -9184,7 +9184,8 @@ static int ufshcd_execute_start_stop(struct scsi_device *sdev,
        };
 
        return scsi_execute_cmd(sdev, cdb, REQ_OP_DRV_IN, /*buffer=*/NULL,
-                       /*bufflen=*/0, /*timeout=*/HZ, /*retries=*/0, &args);
+                       /*bufflen=*/0, /*timeout=*/10 * HZ, /*retries=*/0,
+                       &args);
 }
 
 /**