]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
soundwire: bus: Fix device found flag correctly
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tue, 9 Mar 2021 10:48:16 +0000 (10:48 +0000)
committerVinod Koul <vkoul@kernel.org>
Mon, 22 Mar 2021 12:15:40 +0000 (17:45 +0530)
found flag is used to indicate SoundWire devices that are
both enumerated on the bus and available in the device list.
However this flag is not reset correctly after one iteration,
This could miss some of the devices that are enumerated on the
bus but not in device list. So reset this correctly to fix this issue!

Fixes: d52d7a1be02c ("soundwire: Add Slave status handling helpers")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210309104816.20350-1-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/bus.c

index 46885429928ab817b1d0b07950ad457db28a0119..4ec29338ce9a19a1a3bb0596fc67ab0feeb0d2c7 100644 (file)
@@ -705,7 +705,7 @@ static int sdw_program_device_num(struct sdw_bus *bus)
        struct sdw_slave *slave, *_s;
        struct sdw_slave_id id;
        struct sdw_msg msg;
-       bool found = false;
+       bool found;
        int count = 0, ret;
        u64 addr;
 
@@ -737,6 +737,7 @@ static int sdw_program_device_num(struct sdw_bus *bus)
 
                sdw_extract_slave_id(bus, addr, &id);
 
+               found = false;
                /* Now compare with entries */
                list_for_each_entry_safe(slave, _s, &bus->slaves, node) {
                        if (sdw_compare_devid(slave, id) == 0) {