pps: clients: gpio: Remove redundant condition in ->remove()

The timer along with GPIO API are NULL-aware, there is no need to test
against existing GPIO echo line.

Acked-by: Rodolfo Giometti <giometti@enneenne.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210318130321.24227-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index 78c9680e80633d860f9a417bc8b36ffc1ad009fb..dc9ed6fc3daeaf0ee63b0665079e6fb68f5f5742 100644 (file)
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -240,11 +240,9 @@ static int pps_gpio_remove(struct platform_device *pdev)
        struct pps_gpio_device_data *data = platform_get_drvdata(pdev);
 
        pps_unregister_source(data->pps);
-       if (data->echo_pin) {
-               del_timer_sync(&data->echo_timer);
-               /* reset echo pin in any case */
-               gpiod_set_value(data->echo_pin, 0);
-       }
+       del_timer_sync(&data->echo_timer);
+       /* reset echo pin in any case */
+       gpiod_set_value(data->echo_pin, 0);
        dev_info(&pdev->dev, "removed IRQ %d as PPS source\n", data->irq);
        return 0;
 }