]> www.infradead.org Git - linux.git/commitdiff
arm64: dts: rockchip: Allow Turing RK1 cooling fan to spin down
authorSam Edwards <cfsworks@gmail.com>
Sat, 29 Mar 2025 16:50:17 +0000 (09:50 -0700)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 7 Apr 2025 07:14:59 +0000 (09:14 +0200)
The RK3588 thermal sensor driver only receives interrupts when a
higher-temperature threshold is crossed; it cannot notify when the
sensor cools back off. As a result, the driver must poll for temperature
changes to detect when the conditions for a thermal trip are no longer
met. However, it only does so if the DT enables polling.

Before this patch, the RK1 DT did not enable polling, causing the fan to
continue running at the speed corresponding to the highest temperature
reached.

Follow suit with similar RK3588 boards by setting a polling-delay of
1000ms, enabling the driver to detect when the sensor cools back off,
allowing the fan speed to decrease as appropriate.

Fixes: 7c8ec5e6b9d6 ("arm64: dts: rockchip: Enable automatic fan control on Turing RK1")
Cc: stable@kernel.org # v6.13+
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Link: https://lore.kernel.org/r/20250329165017.3885-1-CFSworks@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi

index 711ac4f2c7cb66d97dc76320f9c87deefcc85dd2..60ad272982ad512d611f4eec0b4ef6d52322eb78 100644 (file)
 };
 
 &package_thermal {
+       polling-delay = <1000>;
+
        trips {
                package_active1: trip-active1 {
                        temperature = <45000>;