fabrics : allow host to create duplicate connections to target

Apparently the nvmf connect code doesn't allow creating
duplicate connections from a host to the same target even
though user specifies option "--duplicate-connect" or "-D".
This patch help fix this issue.

Fixes: 07d6b911e081 ("fabrics: Do not attempt to reconnect to already connected ctrls")
Reported-by: Amit Engel <Amit.Engel@Dell.com>
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Link: https://lore.kernel.org/r/20240403133438.161916-1-nilay@linux.ibm.com
Signed-off-by: Daniel Wagner <dwagner@suse.de>

diff --git a/fabrics.c b/fabrics.c
index 14682907003c7b8457aa4eb5d4961cb8c173bfcf..0f55c6175af184cdd294f5f6d1690af0b88fe22c 100644 (file)
--- a/fabrics.c
+++ b/fabrics.c
@@ -1001,7 +1001,7 @@ int nvmf_connect(const char *desc, int argc, char **argv)
        };
 
        c = lookup_ctrl(h, &trcfg);
-       if (c && nvme_ctrl_get_name(c)) {
+       if (c && nvme_ctrl_get_name(c) && !cfg.duplicate_connect) {
                fprintf(stderr, "already connected\n");
                errno = EALREADY;
                goto out_free;