]> www.infradead.org Git - mtd-utils.git/commitdiff
fs-tests: integrity: don't include header <bits/stdio_lim.h>
authorRahul Bedarkar <rahul.bedarkar@imgtec.com>
Thu, 18 Aug 2016 17:41:30 +0000 (23:11 +0530)
committerRichard Weinberger <richard@nod.at>
Thu, 25 Aug 2016 13:33:09 +0000 (15:33 +0200)
In commit ca7a5eda221d("integck.c: Fix buffer overflow in save_file")
we started including header <bits/stdio_lim.h>.

But with musl C library, we get following build error

  integck.c:37:28: fatal error: bits/stdio_lim.h: No such file or directory
   #include <bits/stdio_lim.h>
                              ^
  compilation terminated.
  make[2]: *** [integck] Error 1

Header <bits/stdio_lim.h> is not available in musl C library. However
<stdio.h> has all definition that <bits/stdio_lim.h> supposed to be
providing. Moreover <bits/stdio_lim.h> shouldn't be included directly
instead we should be using <stdio.h>.

Since we already include <stdio.h> and in case of uClibc or glibc
<bits/stdio_lim.h> gets included internally, we can safely remove it.

This build issue is found by Buildroot autobuilder
http://autobuild.buildroot.net/results/175/1754861457af520480cc34d7d2d0edff2868ff66/

Fixes: ca7a5eda221d("integck.c: Fix buffer overflow in save_file")
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
tests/fs-tests/integrity/integck.c

index 8badd1fe7b8288d723a01fb0e7b88afb57979b91..c6319fb613507735163b2e3784eab02622deab89 100644 (file)
@@ -32,7 +32,6 @@
 #include <assert.h>
 #include <mntent.h>
 #include <execinfo.h>
-#include <bits/stdio_lim.h>
 #include <sys/mman.h>
 #include <sys/vfs.h>
 #include <sys/mount.h>