]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/vc4: hdmi: Remove clock rate initialization
authorMaxime Ripard <maxime@cerno.tech>
Fri, 25 Feb 2022 14:35:34 +0000 (15:35 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 6 Apr 2022 10:41:54 +0000 (12:41 +0200)
Now that the clock driver makes sure we never end up with a rate of 0,
the HDMI driver doesn't need to care anymore.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220225143534.405820-13-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c

index 8b01b1e73becc178f04aefa765d9a848a2c17b1a..e601b29e632b1a46a9f9b5f52b1da0a443a4d081 100644 (file)
@@ -2902,19 +2902,6 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
                        vc4_hdmi->disable_4kp60 = true;
        }
 
-       /*
-        * If we boot without any cable connected to the HDMI connector,
-        * the firmware will skip the HSM initialization and leave it
-        * with a rate of 0, resulting in a bus lockup when we're
-        * accessing the registers even if it's enabled.
-        *
-        * Let's put a sensible default at runtime_resume so that we
-        * don't end up in this situation.
-        */
-       ret = clk_set_min_rate(vc4_hdmi->hsm_clock, HSM_MIN_CLOCK_FREQ);
-       if (ret)
-               goto err_put_ddc;
-
        /*
         * We need to have the device powered up at this point to call
         * our reset hook and for the CEC init.