genwqe: fix MAX_ORDER usage

MAX_ORDER is not inclusive: the maximum allocation order buddy allocator
can deliver is MAX_ORDER-1.

Fix MAX_ORDER usage in genwqe driver.

Link: https://lkml.kernel.org/r/20230315113133.11326-6-kirill.shutemov@linux.intel.com
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/drivers/misc/genwqe/card_dev.c b/drivers/misc/genwqe/card_dev.c
index 55fc5b80e649f329769fd4e141ad782066bfdcf7..d0e27438a73c6cc039acd17a723203e3f1d37bad 100644 (file)
--- a/drivers/misc/genwqe/card_dev.c
+++ b/drivers/misc/genwqe/card_dev.c
@@ -443,7 +443,7 @@ static int genwqe_mmap(struct file *filp, struct vm_area_struct *vma)
        if (vsize == 0)
                return -EINVAL;
 
-       if (get_order(vsize) > MAX_ORDER)
+       if (get_order(vsize) >= MAX_ORDER)
                return -ENOMEM;
 
        dma_map = kzalloc(sizeof(struct dma_mapping), GFP_KERNEL);

diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index f778e11237a687fa66ba65a3f25b0431e36e0def..ac29698d085ab3ff2eae469f60ce2a5acf345bc7 100644 (file)
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -308,7 +308,7 @@ int genwqe_alloc_sync_sgl(struct genwqe_dev *cd, struct genwqe_sgl *sgl,
        sgl->write = write;
        sgl->sgl_size = genwqe_sgl_size(sgl->nr_pages);
 
-       if (get_order(sgl->sgl_size) > MAX_ORDER) {
+       if (get_order(sgl->sgl_size) >= MAX_ORDER) {
                dev_err(&pci_dev->dev,
                        "[%s] err: too much memory requested!\n", __func__);
                return ret;