drm/rockchip: inno-hdmi: Fix infoframe upload

HDMI analyser shows that the AVI infoframe is no being longer send.

The switch to the HDMI connector api should have used the frame content
which is now given in the buffer parameter, but instead still uses the
(now) empty and superfluous packed_frame variable.

Fix it.

Fixes: 65548c8ff0ab ("drm/rockchip: inno_hdmi: Switch to HDMI connector")
Signed-off-by: Alex Bee <knaerzche@gmail.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240805110855.274140-2-knaerzche@gmail.com

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 2241e53a29469090a85891d4ae7f86387c2c0c9b..dec6913cec5b59077123a33e8c886c3fe688ea54 100644 (file)
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -279,7 +279,6 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
                                  const u8 *buffer, size_t len)
 {
        struct inno_hdmi *hdmi = connector_to_inno_hdmi(connector);
-       u8 packed_frame[HDMI_MAXIMUM_INFO_FRAME_SIZE];
        ssize_t i;
 
        if (type != HDMI_INFOFRAME_TYPE_AVI) {
@@ -291,8 +290,7 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
        inno_hdmi_disable_frame(connector, type);
 
        for (i = 0; i < len; i++)
-               hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i,
-                           packed_frame[i]);
+               hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i, buffer[i]);
 
        return 0;
 }