]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
dmaengine: ti: Add NULL check in udma_probe()
authorHenry Martin <bsdhenrymartin@gmail.com>
Wed, 2 Apr 2025 02:39:00 +0000 (10:39 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 14 May 2025 14:27:23 +0000 (15:27 +0100)
devm_kasprintf() returns NULL when memory allocation fails. Currently,
udma_probe() does not check for this case, which results in a NULL
pointer dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Fixes: 25dcb5dd7b7c ("dmaengine: ti: New driver for K3 UDMA")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Reviewed-by: Nathan Lynch <nathan.lynch@amd.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20250402023900.43440-1-bsdhenrymartin@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ti/k3-udma.c

index b223a7aacb0cf155de3120c195d128e5dae6888d..ec914965a45e5d2d78f2af46bb4a50a76c45e7ea 100644 (file)
@@ -5618,7 +5618,8 @@ static int udma_probe(struct platform_device *pdev)
                uc->config.dir = DMA_MEM_TO_MEM;
                uc->name = devm_kasprintf(dev, GFP_KERNEL, "%s chan%d",
                                          dev_name(dev), i);
-
+               if (!uc->name)
+                       return -ENOMEM;
                vchan_init(&uc->vc, &ud->ddev);
                /* Use custom vchan completion handling */
                tasklet_setup(&uc->vc.task, udma_vchan_complete);