]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ice: Remove unnecessary checker loop
authorAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Thu, 25 Mar 2021 22:35:08 +0000 (15:35 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 8 Apr 2021 00:09:15 +0000 (17:09 -0700)
The loop checking for PF VSI doesn't make any sense. The VSI type
backing the netdev passed to ice_set_link_ksettings will always be
of type ICE_PF_VSI. Remove it.

Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_ethtool.c

index 0db31a89658a3327270f41c791015e11773c7aef..c8a8fdac49774b2425481e879bbe6c783f329608 100644 (file)
@@ -2198,8 +2198,8 @@ ice_set_link_ksettings(struct net_device *netdev,
        struct ethtool_link_ksettings safe_ks, copy_ks;
        struct ice_aqc_get_phy_caps_data *abilities;
        u8 autoneg, timeout = TEST_SET_BITS_TIMEOUT;
-       u16 adv_link_speed, curr_link_speed, idx;
        struct ice_aqc_set_phy_cfg_data config;
+       u16 adv_link_speed, curr_link_speed;
        struct ice_pf *pf = np->vsi->back;
        struct ice_port_info *p;
        u8 autoneg_changed = 0;
@@ -2214,14 +2214,6 @@ ice_set_link_ksettings(struct net_device *netdev,
        if (!p)
                return -EOPNOTSUPP;
 
-       /* Check if this is LAN VSI */
-       ice_for_each_vsi(pf, idx)
-               if (pf->vsi[idx]->type == ICE_VSI_PF) {
-                       if (np->vsi != pf->vsi[idx])
-                               return -EOPNOTSUPP;
-                       break;
-               }
-
        if (p->phy.media_type != ICE_MEDIA_BASET &&
            p->phy.media_type != ICE_MEDIA_FIBER &&
            p->phy.media_type != ICE_MEDIA_BACKPLANE &&