]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/i915/display: Move squash_ctl register programming to its own function
authorAnusha Srivatsa <anusha.srivatsa@intel.com>
Tue, 25 Oct 2022 22:30:42 +0000 (15:30 -0700)
committerAnusha Srivatsa <anusha.srivatsa@intel.com>
Wed, 26 Oct 2022 20:45:05 +0000 (13:45 -0700)
No functional change. Introduce dg2_cdclk_squash_program and
move squash_ctl register programming bits to this.

v2: s/dg2_cdclk_squash_programming/dg2_cdclk_squash_program (Jani)

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221025223042.138810-4-anusha.srivatsa@intel.com
drivers/gpu/drm/i915/display/intel_cdclk.c

index 9cd02b85ee51789c4fd2f7a8a4fd02ecd2fc2b2a..eada931cb1c8548918733ba699239be767e9cd1a 100644 (file)
@@ -1704,6 +1704,18 @@ static void bxt_cdclk_pll_update(struct drm_i915_private *i915, int vco)
                bxt_de_pll_enable(i915, vco);
 }
 
+static void dg2_cdclk_squash_program(struct drm_i915_private *i915,
+                                    u16 waveform)
+{
+       u32 squash_ctl = 0;
+
+       if (waveform)
+               squash_ctl = CDCLK_SQUASH_ENABLE |
+                            CDCLK_SQUASH_WINDOW_SIZE(0xf) | waveform;
+
+       intel_de_write(i915, CDCLK_SQUASH_CTL, squash_ctl);
+}
+
 static void bxt_set_cdclk(struct drm_i915_private *dev_priv,
                          const struct intel_cdclk_config *cdclk_config,
                          enum pipe pipe)
@@ -1751,15 +1763,8 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv,
        else
                clock = cdclk;
 
-       if (HAS_CDCLK_SQUASH(dev_priv)) {
-               u32 squash_ctl = 0;
-
-               if (waveform)
-                       squash_ctl = CDCLK_SQUASH_ENABLE |
-                               CDCLK_SQUASH_WINDOW_SIZE(0xf) | waveform;
-
-               intel_de_write(dev_priv, CDCLK_SQUASH_CTL, squash_ctl);
-       }
+       if (HAS_CDCLK_SQUASH(dev_priv))
+               dg2_cdclk_squash_program(dev_priv, waveform);
 
        val = bxt_cdclk_cd2x_div_sel(dev_priv, clock, vco) |
                bxt_cdclk_cd2x_pipe(dev_priv, pipe) |