]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
phy: rockchip: fix Kconfig dependency more
authorArnd Bergmann <arnd@arndb.de>
Wed, 22 Jan 2025 06:52:44 +0000 (07:52 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 4 Feb 2025 05:12:37 +0000 (10:42 +0530)
A previous patch ensured that USB Type C connector support is enabled,
but it is still possible to build the phy driver without enabling
CONFIG_USB (host support) or CONFIG_USB_GADGET (device support), and
in that case the common helper functions are unavailable:

aarch64-linux-ld: drivers/phy/rockchip/phy-rockchip-usbdp.o: in function `rk_udphy_probe':
phy-rockchip-usbdp.c:(.text+0xe74): undefined reference to `usb_get_maximum_speed'

Select CONFIG_USB_COMMON directly here, like we do in some other phy
drivers, to make sure this is available even when actual USB support
is disabled or in a loadable module that cannot be reached from a
built-in phy driver.

Fixes: 9c79b779643e ("phy: rockchip: fix CONFIG_TYPEC dependency")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250122065249.1390081-1-arnd@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/Kconfig

index 2f7a05f21dc595a3346db55d03117d9f95f74e1f..dcb8e1628632e695c7e1d60379af8d210a618416 100644 (file)
@@ -125,6 +125,7 @@ config PHY_ROCKCHIP_USBDP
        depends on ARCH_ROCKCHIP && OF
        depends on TYPEC
        select GENERIC_PHY
+       select USB_COMMON
        help
          Enable this to support the Rockchip USB3.0/DP combo PHY with
          Samsung IP block. This is required for USB3 support on RK3588.