ALSA: firewire: fireworks: Use safer strscpy() instead of strcpy()

Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://patch.msgid.link/20250710100727.22653-18-tiwai@suse.de

diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
index e3ed4e094ccd0e8311a053878cb9d5e7c429a46b..69f722244362ef064feef9660f16931cdde9fa6d 100644 (file)
--- a/sound/firewire/fireworks/fireworks.c
+++ b/sound/firewire/fireworks/fireworks.c
@@ -90,9 +90,9 @@ get_hardware_info(struct snd_efw *efw)
                 (hwinfo->arm_version >> 16) & 0xff);
        efw->firmware_version = hwinfo->arm_version;
 
-       strcpy(efw->card->driver, "Fireworks");
-       strcpy(efw->card->shortname, hwinfo->model_name);
-       strcpy(efw->card->mixername, hwinfo->model_name);
+       strscpy(efw->card->driver, "Fireworks");
+       strscpy(efw->card->shortname, hwinfo->model_name);
+       strscpy(efw->card->mixername, hwinfo->model_name);
        scnprintf(efw->card->longname, sizeof(efw->card->longname),
                  "%s %s v%s, GUID %08x%08x at %s, S%d",
                  hwinfo->vendor_name, hwinfo->model_name, version,

diff --git a/sound/firewire/fireworks/fireworks_hwdep.c b/sound/firewire/fireworks/fireworks_hwdep.c
index 3a53914277d357362d06a72cdf26b1d7589705ea..037833cd066ef5de5b2aad2ccb77214c83a528d1 100644 (file)
--- a/sound/firewire/fireworks/fireworks_hwdep.c
+++ b/sound/firewire/fireworks/fireworks_hwdep.c
@@ -319,7 +319,7 @@ int snd_efw_create_hwdep_device(struct snd_efw *efw)
        err = snd_hwdep_new(efw->card, "Fireworks", 0, &hwdep);
        if (err < 0)
                goto end;
-       strcpy(hwdep->name, "Fireworks");
+       strscpy(hwdep->name, "Fireworks");
        hwdep->iface = SNDRV_HWDEP_IFACE_FW_FIREWORKS;
        hwdep->ops = ops;
        hwdep->private_data = efw;