gpio: vf610: set value before the direction to avoid a glitch

We found a glitch when configuring the pad as output high. To avoid this
glitch, move the data value setting before direction config in the
function vf610_gpio_direction_output().

Fixes: 659d8a62311f ("gpio: vf610: add imx7ulp support")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
[Bartosz: tweak the commit message]
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index d1f05810340fbb23c8be4a5dd0b601fc739171e9..656d6b1dddb5db90725224891b2a164b52a8d6c1 100644 (file)
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -126,14 +126,14 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
        unsigned long mask = BIT(gpio);
        u32 val;
 
+       vf610_gpio_set(chip, gpio, value);
+
        if (port->sdata && port->sdata->have_paddr) {
                val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
                val |= mask;
                vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);
        }
 
-       vf610_gpio_set(chip, gpio, value);
-
        return pinctrl_gpio_direction_output(chip->base + gpio);
 }