]> www.infradead.org Git - users/hch/configfs.git/commitdiff
lib/radix-tree.c: fix uninitialized variable compilation warning
authorRong Tao <rongtao@cestc.cn>
Wed, 9 Nov 2022 14:34:25 +0000 (22:34 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 1 Dec 2022 00:13:17 +0000 (16:13 -0800)
We need to set an initial value for offset to eliminate compilation
warning.

How to reproduce warning:

$ make -C tools/testing/radix-tree
radix-tree.c: In function `radix_tree_tag_clear':
radix-tree.c:1046:17: warning: `offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
 1046 |                 node_tag_clear(root, parent, tag, offset);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Link: https://lkml.kernel.org/r/tencent_DF74099967595DCEA93CBDC28D062026180A@qq.com
Signed-off-by: Rong Tao <rongtao@cestc.cn>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/radix-tree.c

index 3c78e1e8b2ad60ead8b598eb03fc26b1da431155..049ba132f7ef558b8340c82471f757660aa330ce 100644 (file)
@@ -1029,7 +1029,7 @@ void *radix_tree_tag_clear(struct radix_tree_root *root,
 {
        struct radix_tree_node *node, *parent;
        unsigned long maxindex;
-       int offset;
+       int offset = 0;
 
        radix_tree_load_root(root, &node, &maxindex);
        if (index > maxindex)