octeontx2-pf: Fix potential memory leak in otx2_init_tc()

In otx2_init_tc(), if rhashtable_init() failed, it does not free
tc->tc_entries_bitmap which is allocated in otx2_tc_alloc_ent_bitmap().

Fixes: 2e2a8126ffac ("octeontx2-pf: Unify flow management variables")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
index e64318c110fdd4d3b14e6bbac236f53f4d7a47d8..6a01ab1a6e6f3ac7f7293ce8db8af0668d69a28a 100644 (file)
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
@@ -1134,7 +1134,12 @@ int otx2_init_tc(struct otx2_nic *nic)
                return err;
 
        tc->flow_ht_params = tc_flow_ht_params;
-       return rhashtable_init(&tc->flow_table, &tc->flow_ht_params);
+       err = rhashtable_init(&tc->flow_table, &tc->flow_ht_params);
+       if (err) {
+               kfree(tc->tc_entries_bitmap);
+               tc->tc_entries_bitmap = NULL;
+       }
+       return err;
 }
 EXPORT_SYMBOL(otx2_init_tc);