drm/radeon: remove boolean checks in if statements.

Remove unnecessary variable comparisions to true/false in if statements
and check the value of the variable directly.

Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/radeon/cik_sdma.c b/drivers/gpu/drm/radeon/cik_sdma.c
index 35b9dc6ce46a6c6d01a0c4f214116e4c807c1451..68403e77756d333fd8d1ce76d512dfd134f52967 100644 (file)
--- a/drivers/gpu/drm/radeon/cik_sdma.c
+++ b/drivers/gpu/drm/radeon/cik_sdma.c
@@ -333,7 +333,7 @@ void cik_sdma_enable(struct radeon_device *rdev, bool enable)
        u32 me_cntl, reg_offset;
        int i;
 
-       if (enable == false) {
+       if (!enable) {
                cik_sdma_gfx_stop(rdev);
                cik_sdma_rlc_stop(rdev);
        }

diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index 2c1166dc5a82c98bc3d5ef60a0b8e9d40a041d15..24c8db673931a9cd114c011e776f8e155d123c5c 100644 (file)
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -2815,7 +2815,7 @@ void r100_vga_set_state(struct radeon_device *rdev, bool state)
        uint32_t temp;
 
        temp = RREG32(RADEON_CONFIG_CNTL);
-       if (state == false) {
+       if (!state) {
                temp &= ~RADEON_CFG_VGA_RAM_EN;
                temp |= RADEON_CFG_VGA_IO_DIS;
        } else {

diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
index cf1ad4d04d6f0510d3b0ea5bd6e6419e398a2ca5..d9a33ca768f345c2dcb34aa0bec01e705945d92a 100644 (file)
--- a/drivers/gpu/drm/radeon/r600.c
+++ b/drivers/gpu/drm/radeon/r600.c
@@ -3191,7 +3191,7 @@ void r600_vga_set_state(struct radeon_device *rdev, bool state)
        uint32_t temp;
 
        temp = RREG32(CONFIG_CNTL);
-       if (state == false) {
+       if (!state) {
                temp &= ~(1<<0);
                temp |= (1<<1);
        } else {

diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
index c84d965c283ee5ef3db4af8c57309e43a06118bc..c42f73fad3e3156f73b668b559d0231f9ed15b92 100644 (file)
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -664,17 +664,17 @@ bool radeon_get_bios(struct radeon_device *rdev)
        uint16_t tmp;
 
        r = radeon_atrm_get_bios(rdev);
-       if (r == false)
+       if (!r)
                r = radeon_acpi_vfct_bios(rdev);
-       if (r == false)
+       if (!r)
                r = igp_read_bios_from_vram(rdev);
-       if (r == false)
+       if (!r)
                r = radeon_read_bios(rdev);
-       if (r == false)
+       if (!r)
                r = radeon_read_disabled_bios(rdev);
-       if (r == false)
+       if (!r)
                r = radeon_read_platform_bios(rdev);
-       if (r == false || rdev->bios == NULL) {
+       if (!r || rdev->bios == NULL) {
                DRM_ERROR("Unable to locate a BIOS ROM\n");
                rdev->bios = NULL;
                return false;

diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
index 0851e6817e57444e7d4f246c368a9984e8edd8ed..90d2f732affb6db37d06b83f43c54dca1f6805b5 100644 (file)
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -440,7 +440,7 @@ radeon_connector_analog_encoder_conflict_solve(struct drm_connector *connector,
                                if (radeon_conflict->use_digital)
                                        continue;
 
-                               if (priority == true) {
+                               if (priority) {
                                        DRM_DEBUG_KMS("1: conflicting encoders switching off %s\n",
                                                      conflict->name);
                                        DRM_DEBUG_KMS("in favor of %s\n",
@@ -700,7 +700,7 @@ static int radeon_connector_set_property(struct drm_connector *connector, struct
                        else
                                ret = radeon_legacy_get_tmds_info_from_combios(radeon_encoder, tmds);
                }
-               if (val == 1 || ret == false) {
+               if (val == 1 || !ret) {
                        radeon_legacy_get_tmds_info_from_table(radeon_encoder, tmds);
                }
                radeon_property_change_mode(&radeon_encoder->base);

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 962575e27cdecfb587ab38b247bebe3ba60dbdc2..856526cb2caf229820552a3fe4b2bcd3c309d3eb 100644 (file)
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -847,11 +847,11 @@ static bool radeon_setup_enc_conn(struct drm_device *dev)
        if (rdev->bios) {
                if (rdev->is_atom_bios) {
                        ret = radeon_get_atom_connector_info_from_supported_devices_table(dev);
-                       if (ret == false)
+                       if (!ret)
                                ret = radeon_get_atom_connector_info_from_object_table(dev);
                } else {
                        ret = radeon_get_legacy_connector_info_from_bios(dev);
-                       if (ret == false)
+                       if (!ret)
                                ret = radeon_get_legacy_connector_info_from_table(dev);
                }
        } else {

diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index a33b19566b2d46b45212cfe2814c764eb01f36a5..44d060f75318e0ad36774bc6e644a7c6e43ac545 100644 (file)
--- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
@@ -1712,7 +1712,7 @@ static struct radeon_encoder_int_tmds *radeon_legacy_get_tmds_info(struct radeon
        else
                ret = radeon_legacy_get_tmds_info_from_combios(encoder, tmds);
 
-       if (ret == false)
+       if (!ret)
                radeon_legacy_get_tmds_info_from_table(encoder, tmds);
 
        return tmds;
@@ -1735,7 +1735,7 @@ static struct radeon_encoder_ext_tmds *radeon_legacy_get_ext_tmds_info(struct ra
 
        ret = radeon_legacy_get_ext_tmds_info_from_combios(encoder, tmds);
 
-       if (ret == false)
+       if (!ret)
                radeon_legacy_get_ext_tmds_info_from_table(encoder, tmds);
 
        return tmds;

diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index b37121f2631d5c424d23326bb7307691a7eaca4d..8c5d6fda0d757da41d0145f5aece5ef9fbcf67a6 100644 (file)
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -1789,7 +1789,7 @@ static bool radeon_pm_debug_check_in_vbl(struct radeon_device *rdev, bool finish
        u32 stat_crtc = 0;
        bool in_vbl = radeon_pm_in_vbl(rdev);
 
-       if (in_vbl == false)
+       if (!in_vbl)
                DRM_DEBUG_DRIVER("not in vbl for pm change %08x at %s\n", stat_crtc,
                         finish ? "exit" : "entry");
        return in_vbl;