]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
net: usb: rtl8150 fix unintiatilzed variables in rtl8150_get_link_ksettings
authorOliver Neukum <oneukum@suse.com>
Wed, 19 Jun 2024 13:28:03 +0000 (15:28 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 20 Jun 2024 14:15:17 +0000 (07:15 -0700)
This functions retrieves values by passing a pointer. As the function
that retrieves them can fail before touching the pointers, the variables
must be initialized.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: syzbot+5186630949e3c55f0799@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Link: https://lore.kernel.org/r/20240619132816.11526-1-oneukum@suse.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/rtl8150.c

index 97afd7335d8685581b317c3a5311bccfd1679770..01a3b2417a5401c19a53807675662ef415b90cbb 100644 (file)
@@ -778,7 +778,8 @@ static int rtl8150_get_link_ksettings(struct net_device *netdev,
                                      struct ethtool_link_ksettings *ecmd)
 {
        rtl8150_t *dev = netdev_priv(netdev);
-       short lpa, bmcr;
+       short lpa = 0;
+       short bmcr = 0;
        u32 supported;
 
        supported = (SUPPORTED_10baseT_Half |