scsi: cxlflash: Add argument identifier names

Checkpatch throws a warning when the argument identifier names are not
included in the function definitions.

To avoid these warnings, argument identifiers are added in the existing
function definitions.

Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/cxlflash/backend.h b/drivers/scsi/cxlflash/backend.h
index 339e42b03c49d22eff1596a020749d3b35f30385..7b721497ae222878eef6288266493dcd194c0c5f 100644 (file)
--- a/drivers/scsi/cxlflash/backend.h
+++ b/drivers/scsi/cxlflash/backend.h
@@ -16,26 +16,29 @@ extern const struct cxlflash_backend_ops cxlflash_cxl_ops;
 
 struct cxlflash_backend_ops {
        struct module *module;
-       void __iomem * (*psa_map)(void *);
-       void (*psa_unmap)(void __iomem *);
-       int (*process_element)(void *);
-       int (*map_afu_irq)(void *, int, irq_handler_t, void *, char *);
-       void (*unmap_afu_irq)(void *, int, void *);
-       int (*start_context)(void *);
-       int (*stop_context)(void *);
-       int (*afu_reset)(void *);
-       void (*set_master)(void *);
-       void * (*get_context)(struct pci_dev *, void *);
-       void * (*dev_context_init)(struct pci_dev *, void *);
-       int (*release_context)(void *);
-       void (*perst_reloads_same_image)(void *, bool);
-       ssize_t (*read_adapter_vpd)(struct pci_dev *, void *, size_t);
-       int (*allocate_afu_irqs)(void *, int);
-       void (*free_afu_irqs)(void *);
-       void * (*create_afu)(struct pci_dev *);
-       struct file * (*get_fd)(void *, struct file_operations *, int *);
-       void * (*fops_get_context)(struct file *);
-       int (*start_work)(void *, u64);
-       int (*fd_mmap)(struct file *, struct vm_area_struct *);
-       int (*fd_release)(struct inode *, struct file *);
+       void __iomem * (*psa_map)(void *ctx_cookie);
+       void (*psa_unmap)(void __iomem *addr);
+       int (*process_element)(void *ctx_cookie);
+       int (*map_afu_irq)(void *ctx_cookie, int num, irq_handler_t handler,
+                          void *cookie, char *name);
+       void (*unmap_afu_irq)(void *ctx_cookie, int num, void *cookie);
+       int (*start_context)(void *ctx_cookie);
+       int (*stop_context)(void *ctx_cookie);
+       int (*afu_reset)(void *ctx_cookie);
+       void (*set_master)(void *ctx_cookie);
+       void * (*get_context)(struct pci_dev *dev, void *afu_cookie);
+       void * (*dev_context_init)(struct pci_dev *dev, void *afu_cookie);
+       int (*release_context)(void *ctx_cookie);
+       void (*perst_reloads_same_image)(void *afu_cookie, bool image);
+       ssize_t (*read_adapter_vpd)(struct pci_dev *dev, void *buf,
+                                   size_t count);
+       int (*allocate_afu_irqs)(void *ctx_cookie, int num);
+       void (*free_afu_irqs)(void *ctx_cookie);
+       void * (*create_afu)(struct pci_dev *dev);
+       struct file * (*get_fd)(void *ctx_cookie, struct file_operations *fops,
+                               int *fd);
+       void * (*fops_get_context)(struct file *file);
+       int (*start_work)(void *ctx_cookie, u64 irqs);
+       int (*fd_mmap)(struct file *file, struct vm_area_struct *vm);
+       int (*fd_release)(struct inode *inode, struct file *file);
 };

diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h
index 715c63c088922c276709fb375a1797ab51cad34e..ffcb1c62fbb7851338dd16f7b67784e2c42dbcd0 100644 (file)
--- a/drivers/scsi/cxlflash/common.h
+++ b/drivers/scsi/cxlflash/common.h
@@ -232,8 +232,8 @@ struct hwq {
 
 struct afu {
        struct hwq hwqs[CXLFLASH_MAX_HWQS];
-       int (*send_cmd)(struct afu *, struct afu_cmd *);
-       int (*context_reset)(struct hwq *);
+       int (*send_cmd)(struct afu *afu, struct afu_cmd *cmd);
+       int (*context_reset)(struct hwq *hwq);
 
        /* AFU HW */
        struct cxlflash_afu_map __iomem *afu_map;       /* entire MMIO map */