]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
scsi: scsi_debug: Avoid PI being disabled when TPGS is enabled v4.1.12-108.0.20170806_1300
authorMartin K. Petersen <martin.petersen@oracle.com>
Fri, 19 May 2017 16:39:36 +0000 (12:39 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Sun, 6 Aug 2017 18:29:28 +0000 (11:29 -0700)
It was not possible to enable both T10 PI and TPGS because they share
the same byte in the INQUIRY response. Logically OR the TPGS value
instead of using assignment.

Orabug: 25704090

Reported-by: Ritika Srivastava <ritika.srivastava@oracle.com>
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
(cherry picked from commit 70bdf2026d905b8bfa0a455d35018df3e9777a6c)
Signed-off-by: Ritika Srivastava <ritika.srivastava@oracle.com>
Reviewed-by: John Sobecki <john.sobecki@oracle.com>
Conflicts:
drivers/scsi/scsi_debug.c

drivers/scsi/scsi_debug.c

index 1f8e2dc9c616a0b7e02559537c05b109123b5b80..1e27127c2c586a3fa1baeede78a3cf1985e2e47d 100644 (file)
@@ -1398,7 +1398,7 @@ static int resp_inquiry(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
        arr[4] = SDEBUG_LONG_INQ_SZ - 5;
        arr[5] = scsi_debug_dif ? 1 : 0; /* PROTECT bit */
        if (0 == scsi_debug_vpd_use_hostno)
-               arr[5] = 0x10; /* claim: implicit TGPS */
+               arr[5] |= 0x10; /* claim: implicit TPGS */
        arr[6] = 0x10; /* claim: MultiP */
        /* arr[6] |= 0x40; ... claim: EncServ (enclosure services) */
        arr[7] = 0xa; /* claim: LINKED + CMDQUE */