]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
bnx2x: Add known PHY type check
authorYaniv Rosner <yanivr@broadcom.com>
Mon, 28 Nov 2011 00:49:50 +0000 (00:49 +0000)
committerJoe Jin <joe.jin@oracle.com>
Wed, 16 May 2012 14:41:08 +0000 (22:41 +0800)
The populate function will fail in case an unknown external PHY is detected.

(cherry picked from commit 6db5193b29642ab18e6343c8fcbc3417d6e80983)
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/net/bnx2x/bnx2x_link.c

index 7fa7177fa60330ac6b434a3d9d3586bb369fc5fe..0e3c8950a6c8ccdf8553c73f41212754506bfd47 100644 (file)
@@ -11483,6 +11483,10 @@ static int bnx2x_populate_ext_phy(struct bnx2x *bp,
                return -EINVAL;
        default:
                *phy = phy_null;
+               /* In case external PHY wasn't found */
+               if ((phy_type != PORT_HW_CFG_XGXS_EXT_PHY_TYPE_DIRECT) &&
+                   (phy_type != PORT_HW_CFG_XGXS_EXT_PHY_TYPE_NOT_CONN))
+                       return -EINVAL;
                return 0;
        }