]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme-cli: Ignore traddr case
authorDaniel Wagner <dwagner@suse.de>
Tue, 1 Mar 2022 15:10:25 +0000 (16:10 +0100)
committerDaniel Wagner <dwagner@suse.de>
Tue, 1 Mar 2022 15:10:25 +0000 (16:10 +0100)
There was is no requirement in the NVME-FC specification that traddr
needs to be upper or lower case. Given the case difference, the
connect-all fails the match logic. Switch to strcasecmp for a
case insensitive compare.

Based on 1264c6323937 ("nvme-cli: Make connect-all matching be case
insensitive")

Signed-off-by: Daniel Wagner <dwagner@suse.de>
fabrics.c

index e4dd3a589631f30a883d4ecc703d2c2948467af8..49378dce5d59906061ed251bc00f24350bd6607e 100644 (file)
--- a/fabrics.c
+++ b/fabrics.c
@@ -511,7 +511,7 @@ int nvmf_discover(const char *desc, int argc, char **argv, bool connect)
                        /* Check if device matches command-line options */
                        if (strcmp(nvme_ctrl_get_subsysnqn(c), subsysnqn) ||
                            strcmp(nvme_ctrl_get_transport(c), transport) ||
-                           strcmp(nvme_ctrl_get_traddr(c), traddr) ||
+                           strcasecmp(nvme_ctrl_get_traddr(c), traddr) ||
                            (cfg.host_traddr && nvme_ctrl_get_host_traddr(c) &&
                             strcmp(nvme_ctrl_get_host_traddr(c),
                                    cfg.host_traddr)) ||