]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
USB: core: remove dead code in do_proc_bulk()
authorRex Nie <rex.nie@jaguarmicro.com>
Tue, 12 Nov 2024 15:20:22 +0000 (23:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Nov 2024 06:06:41 +0000 (07:06 +0100)
Since len1 is unsigned int, len1 < 0 always false. Remove it keep code
simple.

Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
Rule: add
Link: https://lore.kernel.org/stable/20241108094255.2133-1-rex.nie%40jaguarmicro.com
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20241112152021.2236-1-rex.nie@jaguarmicro.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/devio.c

index 5363468a282f82b66196623225258a1bb54941aa..f6ce6e26e0d45f67704f40b27c5a09cde9111259 100644 (file)
@@ -1298,7 +1298,7 @@ static int do_proc_bulk(struct usb_dev_state *ps,
                return ret;
 
        len1 = bulk->len;
-       if (len1 < 0 || len1 >= (INT_MAX - sizeof(struct urb)))
+       if (len1 >= (INT_MAX - sizeof(struct urb)))
                return -EINVAL;
 
        if (bulk->ep & USB_DIR_IN)