]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
regmap: spmi: Fix regmap_spmi_ext_read in multi-byte case
authorJack Pham <jackp@codeaurora.org>
Fri, 15 Apr 2016 06:37:26 +0000 (23:37 -0700)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:21:50 +0000 (17:21 -0500)
Orabug: 25227137

[ Upstream commit dec8e8f6e6504aa3496c0f7cc10c756bb0e10f44 ]

Specifically for the case of reads that use the Extended Register
Read Long command, a multi-byte read operation is broken up into
8-byte chunks.  However the call to spmi_ext_register_readl() is
incorrectly passing 'val_size', which if greater than 8 will
always fail.  The argument should instead be 'len'.

Fixes: c9afbb05a9ff ("regmap: spmi: support base and extended register spaces")
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 24a50739c3e4e9947f4f4a28a023c348d7bea042)

Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/base/regmap/regmap-spmi.c

index d7026dc33388aada6003886d14d8d73f264b56a9..b394aaef386735ca996add7829379635aed541be 100644 (file)
@@ -153,7 +153,7 @@ static int regmap_spmi_ext_read(void *context,
        while (val_size) {
                len = min_t(size_t, val_size, 8);
 
-               err = spmi_ext_register_readl(context, addr, val, val_size);
+               err = spmi_ext_register_readl(context, addr, val, len);
                if (err)
                        goto err_out;