]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: gyro: fxas21002c: Fix missing data update in trigger handler
authorCarlos Song <carlos.song@nxp.com>
Sat, 16 Nov 2024 15:29:45 +0000 (10:29 -0500)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 7 Dec 2024 17:13:25 +0000 (17:13 +0000)
The fxas21002c_trigger_handler() may fail to acquire sample data because
the runtime PM enters the autosuspend state and sensor can not return
sample data in standby mode..

Resume the sensor before reading the sample data into the buffer within the
trigger handler. After the data is read, place the sensor back into the
autosuspend state.

Fixes: a0701b6263ae ("iio: gyro: add core driver for fxas21002c")
Signed-off-by: Carlos Song <carlos.song@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20241116152945.4006374-1-Frank.Li@nxp.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/gyro/fxas21002c_core.c

index 0391c78c2f186fa2ed9a728c31cbebe044ab9a6f..754c8a564ba46ad796c4fce3cf61d3eb0e806f20 100644 (file)
@@ -730,14 +730,21 @@ static irqreturn_t fxas21002c_trigger_handler(int irq, void *p)
        int ret;
 
        mutex_lock(&data->lock);
+       ret = fxas21002c_pm_get(data);
+       if (ret < 0)
+               goto out_unlock;
+
        ret = regmap_bulk_read(data->regmap, FXAS21002C_REG_OUT_X_MSB,
                               data->buffer, CHANNEL_SCAN_MAX * sizeof(s16));
        if (ret < 0)
-               goto out_unlock;
+               goto out_pm_put;
 
        iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
                                           data->timestamp);
 
+out_pm_put:
+       fxas21002c_pm_put(data);
+
 out_unlock:
        mutex_unlock(&data->lock);