ice: remove rx_len_errors statistic

It was found that this statistic is incorrectly
reported by HW and thus, useless.

As RX length error statistics are shown to the
end user when requested, the values reported
are misleading.

Thus, that value is no longer reported and
doesn't count anymore when adding all rx errors.

Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index 2244d41fd93379be1a921b6955d2ad5b83e241ff..a19b06f18e400529a4bb1f16131511438f1bde59 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -129,7 +129,6 @@ static const struct ice_stats ice_gstrings_pf_stats[] = {
        ICE_PF_STAT("rx_oversize.nic", stats.rx_oversize),
        ICE_PF_STAT("rx_jabber.nic", stats.rx_jabber),
        ICE_PF_STAT("rx_csum_bad.nic", hw_csum_rx_error),
-       ICE_PF_STAT("rx_length_errors.nic", stats.rx_len_errors),
        ICE_PF_STAT("rx_dropped.nic", stats.eth.rx_discards),
        ICE_PF_STAT("rx_crc_errors.nic", stats.crc_errors),
        ICE_PF_STAT("illegal_bytes.nic", stats.illegal_bytes),

diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 2fa46bacf5ba88c529e4e9600c05d3f90f4090a3..63a5fb701ada9a7a0d94d98350486415005b92d8 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -6834,13 +6834,11 @@ void ice_update_vsi_stats(struct ice_vsi *vsi)
                cur_ns->rx_crc_errors = pf->stats.crc_errors;
                cur_ns->rx_errors = pf->stats.crc_errors +
                                    pf->stats.illegal_bytes +
-                                   pf->stats.rx_len_errors +
                                    pf->stats.rx_undersize +
                                    pf->hw_csum_rx_error +
                                    pf->stats.rx_jabber +
                                    pf->stats.rx_fragments +
                                    pf->stats.rx_oversize;
-               cur_ns->rx_length_errors = pf->stats.rx_len_errors;
                /* record drops from the port level */
                cur_ns->rx_missed_errors = pf->stats.eth.rx_discards;
        }
@@ -6980,9 +6978,6 @@ void ice_update_pf_stats(struct ice_pf *pf)
                          &prev_ps->mac_remote_faults,
                          &cur_ps->mac_remote_faults);
 
-       ice_stat_update32(hw, GLPRT_RLEC(port), pf->stat_prev_loaded,
-                         &prev_ps->rx_len_errors, &cur_ps->rx_len_errors);
-
        ice_stat_update32(hw, GLPRT_RUC(port), pf->stat_prev_loaded,
                          &prev_ps->rx_undersize, &cur_ps->rx_undersize);
 

diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
index 5f04b1318c9ecae647cd51f2e11bafe1af5efa03..41ab6d7bbd9ef923fb766555ba48c5533e989f93 100644 (file)
--- a/drivers/net/ethernet/intel/ice/ice_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_type.h
@@ -1003,7 +1003,6 @@ struct ice_hw_port_stats {
        u64 error_bytes;                /* errbc */
        u64 mac_local_faults;           /* mlfc */
        u64 mac_remote_faults;          /* mrfc */
-       u64 rx_len_errors;              /* rlec */
        u64 link_xon_rx;                /* lxonrxc */
        u64 link_xoff_rx;               /* lxoffrxc */
        u64 link_xon_tx;                /* lxontxc */