]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: qcom: Adjust issues in case of DT error in asoc_qcom_lpass_cpu_platform_probe()
authorAleksandr Mishin <amishin@t-argos.ru>
Wed, 5 Jun 2024 10:49:53 +0000 (13:49 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 26 Jun 2024 17:35:51 +0000 (18:35 +0100)
If IORESOURCE_MEM "lpass-rxtx-cdc-dma-lpm" or "lpass-va-cdc-dma-lpm"
resources is not provided in Device Tree due to any error,
platform_get_resource_byname() will return NULL which is later
dereferenced. According to sound/qcom,lpass-cpu.yaml, these resources
are provided, but DT can be broken due to any error. In such cases driver
must be able to protect itself, since the DT is external data for the
driver.
Adjust this issues by adding NULL return check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: b138706225c9 ("ASoC: qcom: Add regmap config support for codec dma driver")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Link: https://patch.msgid.link/20240605104953.12072-1-amishin@t-argos.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-cpu.c

index b0f3e02cb043c6c46af732b5d4202af3ed2f51fa..5a47f661e0c6f79599aba9361bfed99f1bd93f90 100644 (file)
@@ -1166,9 +1166,13 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
                }
 
                res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-rxtx-cdc-dma-lpm");
+               if (!res)
+                       return -EINVAL;
                drvdata->rxtx_cdc_dma_lpm_buf = res->start;
 
                res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-va-cdc-dma-lpm");
+               if (!res)
+                       return -EINVAL;
                drvdata->va_cdc_dma_lpm_buf = res->start;
        }