]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme: Use self-test code definition values instead hard-coded values
authorTokunori Ikegami <ikegami.t@gmail.com>
Fri, 27 Jan 2023 16:16:46 +0000 (01:16 +0900)
committerDaniel Wagner <dwagner@suse.de>
Mon, 30 Jan 2023 12:36:02 +0000 (13:36 +0100)
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
nvme.c

diff --git a/nvme.c b/nvme.c
index 7aad55f26dd98f96a37d49993a2e9c7a8e21d756..d0f91fe8700bc4e0c97a3c6b5d8bf29276ec4219 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -4246,7 +4246,7 @@ static int device_self_test(int argc, char **argv, struct command *cmd, struct p
 
        struct config cfg = {
                .namespace_id   = NVME_NSID_ALL,
-               .stc            = 0,
+               .stc            = NVME_ST_CODE_RESERVED,
                .wait           = false,
        };
 
@@ -4261,7 +4261,7 @@ static int device_self_test(int argc, char **argv, struct command *cmd, struct p
        if (err)
                goto ret;
 
-       if (cfg.stc == 0) {
+       if (cfg.stc == NVME_ST_CODE_RESERVED) {
                struct nvme_self_test_log log;
                err = nvme_cli_get_log_device_self_test(dev, &log);
                if (err) {
@@ -4295,9 +4295,9 @@ static int device_self_test(int argc, char **argv, struct command *cmd, struct p
        if (!err) {
                if (cfg.stc == 0xf)
                        printf("Aborting device self-test operation\n");
-               else if (cfg.stc == 0x2)
+               else if (cfg.stc == NVME_ST_CODE_EXTENDED)
                        printf("Extended Device self-test started\n");
-               else if (cfg.stc == 0x1)
+               else if (cfg.stc == NVME_ST_CODE_SHORT)
                        printf("Short Device self-test started\n");
 
                if (cfg.wait)