]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
kallsyms: add more original symbol type/name in comment lines
authorMasahiro Yamada <masahiroy@kernel.org>
Sat, 20 Jul 2024 10:30:14 +0000 (19:30 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sun, 21 Jul 2024 16:24:22 +0000 (01:24 +0900)
Commit bea5b7450474 ("kallsyms: expand symbol name into comment for
debugging") added the uncompressed type/name in the comment lines of
kallsyms_offsets.

It would be useful to do the same for kallsyms_names and
kallsyms_seqs_of_names.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kallsyms.c

index 164c04d2206144fc0b7646e4f0d74f874627c17d..e291e34a450b3fb43c7e3a14dff83bdc1a7306bd 100644 (file)
@@ -456,18 +456,16 @@ static void write_src(void)
                }
                for (k = 0; k < table[i]->len; k++)
                        printf(", 0x%02x", table[i]->sym[k]);
-               printf("\n");
-       }
-       printf("\n");
 
-       /*
-        * Now that we wrote out the compressed symbol names, restore the
-        * original names, which are needed in some of the later steps.
-        */
-       for (i = 0; i < table_cnt; i++) {
+               /*
+                * Now that we wrote out the compressed symbol name, restore the
+                * original name and print it in the comment.
+                */
                expand_symbol(table[i]->sym, table[i]->len, buf);
                strcpy((char *)table[i]->sym, buf);
+               printf("\t/* %s */\n", table[i]->sym);
        }
+       printf("\n");
 
        output_label("kallsyms_markers");
        for (i = 0; i < markers_cnt; i++)
@@ -536,10 +534,11 @@ static void write_src(void)
        sort_symbols_by_name();
        output_label("kallsyms_seqs_of_names");
        for (i = 0; i < table_cnt; i++)
-               printf("\t.byte 0x%02x, 0x%02x, 0x%02x\n",
+               printf("\t.byte 0x%02x, 0x%02x, 0x%02x\t/* %s */\n",
                        (unsigned char)(table[i]->seq >> 16),
                        (unsigned char)(table[i]->seq >> 8),
-                       (unsigned char)(table[i]->seq >> 0));
+                       (unsigned char)(table[i]->seq >> 0),
+                      table[i]->sym);
        printf("\n");
 }