]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
da8xx-cfgchip.c: replace of_node_put with __free improves cleanup
authorDavid Hunter <david.hunter.linux@gmail.com>
Sat, 20 Jul 2024 15:24:47 +0000 (11:24 -0400)
committerStephen Boyd <sboyd@kernel.org>
Mon, 29 Jul 2024 23:12:50 +0000 (16:12 -0700)
The use of the __free function allows the cleanup to be based on scope
instead of on another function called later. This makes the cleanup
automatic and less susceptible to errors later.

This code was compiled without errors or warnings.

Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
Link: https://lore.kernel.org/r/20240720152447.311442-1-david.hunter.linux@gmail.com
Reviewed-by: David Lechner <david@lechnology.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/davinci/da8xx-cfgchip.c

index ec60ecb517f1f9939acc38386dfaab7da27f4bac..f6da6674857302eb7062ce38a120a8cab9f4810e 100644 (file)
@@ -749,11 +749,9 @@ static int da8xx_cfgchip_probe(struct platform_device *pdev)
 
        clk_init = device_get_match_data(dev);
        if (clk_init) {
-               struct device_node *parent;
+               struct device_node *parent __free(device_node) = of_get_parent(dev->of_node);
 
-               parent = of_get_parent(dev->of_node);
                regmap = syscon_node_to_regmap(parent);
-               of_node_put(parent);
        } else if (pdev->id_entry && pdata) {
                clk_init = (void *)pdev->id_entry->driver_data;
                regmap = pdata->cfgchip;