mm-pgtable-convert-some-architectures-to-use-tlb_remove_ptdesc-v2

remove the do { ... } while construct, per Geert

Link: https://lkml.kernel.org/r/20250303072603.45423-1-zhengqi.arch@bytedance.com
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Suggested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kevin Brodsky <kevin.brodsky@arm.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> # m68k
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Hugh Dickens <hughd@google.com>
Cc: Jann Horn <jannh@google.com>
Cc: Matthew Wilcow (Oracle) <willy@infradead.org>
Cc: "Mike Rapoport (IBM)" <rppt@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h
index 9d2b50265a8d82fb1fcd55142ea74d98600fded0..11055c5749686c8a551b582d5ed7f55bdac203b7 100644 (file)
--- a/arch/csky/include/asm/pgalloc.h
+++ b/arch/csky/include/asm/pgalloc.h
@@ -61,10 +61,8 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm)
        return ret;
 }
 
-#define __pte_free_tlb(tlb, pte, address)              \
-do {                                                   \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));     \
-} while (0)
+#define __pte_free_tlb(tlb, pte, address)      \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 extern void pagetable_init(void);
 extern void mmu_init(unsigned long min_pfn, unsigned long max_pfn);

diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h
index 3d35d2bc425342e1f02b53e1c877dbe1287d8236..937a11ef4c33c8250b35856bfb9cadccbf9c7f48 100644 (file)
--- a/arch/hexagon/include/asm/pgalloc.h
+++ b/arch/hexagon/include/asm/pgalloc.h
@@ -87,9 +87,7 @@ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd,
                max_kernel_seg = pmdindex;
 }
 
-#define __pte_free_tlb(tlb, pte, addr)                         \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, addr) \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 #endif

diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h
index ac026146e7e9588f8152053616429d8a669f4744..73629c1b8328edf6963dac05767137958cd4390a 100644 (file)
--- a/arch/loongarch/include/asm/pgalloc.h
+++ b/arch/loongarch/include/asm/pgalloc.h
@@ -55,10 +55,8 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm)
        return pte;
 }
 
-#define __pte_free_tlb(tlb, pte, address)                      \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, address)      \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte));
 
 #ifndef __PAGETABLE_PMD_FOLDED
 

diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h
index ddc24812f18329ac109835f1be74c41155348e57..1e21c758b774e75869537cb894c7023f4d494204 100644 (file)
--- a/arch/m68k/include/asm/sun3_pgalloc.h
+++ b/arch/m68k/include/asm/sun3_pgalloc.h
@@ -17,10 +17,8 @@
 
 extern const char bad_pmd_string[];
 
-#define __pte_free_tlb(tlb, pte, addr)                         \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, addr) \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte)
 {

diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h
index 7e73d2f913dd49a7223df57840a3eab8b1385b5b..bbca420c96d3c096171976853a99d1e3b171b421 100644 (file)
--- a/arch/mips/include/asm/pgalloc.h
+++ b/arch/mips/include/asm/pgalloc.h
@@ -48,10 +48,8 @@ static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd)
 extern void pgd_init(void *addr);
 extern pgd_t *pgd_alloc(struct mm_struct *mm);
 
-#define __pte_free_tlb(tlb, pte, address)                      \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, address)      \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 #ifndef __PAGETABLE_PMD_FOLDED
 

diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h
index 4b4a1766e2cc71c2de8b148d2974c996e563e105..db122b093a8bed73103be6fc738bd6105014e792 100644 (file)
--- a/arch/nios2/include/asm/pgalloc.h
+++ b/arch/nios2/include/asm/pgalloc.h
@@ -28,9 +28,7 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
 
 extern pgd_t *pgd_alloc(struct mm_struct *mm);
 
-#define __pte_free_tlb(tlb, pte, addr)                         \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, addr) \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 #endif /* _ASM_NIOS2_PGALLOC_H */

diff --git a/arch/openrisc/include/asm/pgalloc.h b/arch/openrisc/include/asm/pgalloc.h
index 2964e26980a188993d48ca8f9e9d5e2c65c59eb8..3f110931d8f6ef1406dfbc46931acba5b6e315f9 100644 (file)
--- a/arch/openrisc/include/asm/pgalloc.h
+++ b/arch/openrisc/include/asm/pgalloc.h
@@ -64,9 +64,7 @@ extern inline pgd_t *pgd_alloc(struct mm_struct *mm)
 
 extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm);
 
-#define __pte_free_tlb(tlb, pte, addr)                         \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, addr) \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 #endif

diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h
index c376d4b708fda74599430c0b548a48facba182c1..6fe7123d38fa9e35b314cb1e6eacc8655eb24a81 100644 (file)
--- a/arch/sh/include/asm/pgalloc.h
+++ b/arch/sh/include/asm/pgalloc.h
@@ -32,9 +32,7 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,
        set_pmd(pmd, __pmd((unsigned long)page_address(pte)));
 }
 
-#define __pte_free_tlb(tlb, pte, addr)                         \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, addr) \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 #endif /* __ASM_SH_PGALLOC_H */

diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h
index a70151cfd11c9a98ad3d2fc292a2557e0e2d8509..826ec44b58cdb546c2901b699a7fbdf4cf4c53e8 100644 (file)
--- a/arch/um/include/asm/pgalloc.h
+++ b/arch/um/include/asm/pgalloc.h
@@ -25,24 +25,18 @@
  */
 extern pgd_t *pgd_alloc(struct mm_struct *);
 
-#define __pte_free_tlb(tlb, pte, address)                      \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), page_ptdesc(pte));             \
-} while (0)
+#define __pte_free_tlb(tlb, pte, address)      \
+       tlb_remove_ptdesc((tlb), page_ptdesc(pte))
 
 #if CONFIG_PGTABLE_LEVELS > 2
 
-#define __pmd_free_tlb(tlb, pmd, address)                      \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), virt_to_ptdesc(pmd));          \
-} while (0)
+#define __pmd_free_tlb(tlb, pmd, address)      \
+       tlb_remove_ptdesc((tlb), virt_to_ptdesc(pmd))
 
 #if CONFIG_PGTABLE_LEVELS > 3
 
-#define __pud_free_tlb(tlb, pud, address)                      \
-do {                                                           \
-       tlb_remove_ptdesc((tlb), virt_to_ptdesc(pud));          \
-} while (0)
+#define __pud_free_tlb(tlb, pud, address)      \
+       tlb_remove_ptdesc((tlb), virt_to_ptdesc(pud))
 
 #endif
 #endif