]> www.infradead.org Git - users/hch/misc.git/commitdiff
ALSA: usb: fcp: Fix hwdep read ops types
authorStephen Rothwell <sfr@canb.auug.org.au>
Mon, 20 Jan 2025 03:56:17 +0000 (14:56 +1100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 20 Jan 2025 07:37:51 +0000 (08:37 +0100)
The FCP driver defined hwdep read function with ssize_t, but it should
be long due to historical reason.  This caused build errors on 32bit
archs.

Fixes: 46757a3e7d50 ("ALSA: FCP: Add Focusrite Control Protocol driver")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: https://patch.msgid.link/20250120145617.07945574@canb.auug.org.au
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/fcp.c

index 655e4f7338edae5508a25c162221dc74a59a0cd8..ecdd18335ab79c63e76d0aa0e14fb45763a32db5 100644 (file)
@@ -815,13 +815,13 @@ static int fcp_hwdep_ioctl(struct snd_hwdep *hw, struct file *file,
        /* not reached */
 }
 
-static ssize_t fcp_hwdep_read(struct snd_hwdep *hw, char __user *buf,
-                             ssize_t count, loff_t *offset)
+static long fcp_hwdep_read(struct snd_hwdep *hw, char __user *buf,
+                          long count, loff_t *offset)
 {
        struct usb_mixer_interface *mixer = hw->private_data;
        struct fcp_data *private = mixer->private_data;
        unsigned long flags;
-       ssize_t ret = 0;
+       long ret = 0;
        u32 event;
 
        if (count < sizeof(event))