ionic: tame the filter no space message

Override the automatic AdminQ error message in order to
capture the potential No Space message when we hit the
max vlan limit, and add additional messaging to detail
what filter failed.

Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
index 366f1579486692c858cf5dc0591224c8d2870b69..f6e785f949f9f92324fd47011465655a8bc8feaf 100644 (file)
--- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
@@ -357,7 +357,7 @@ static int ionic_lif_filter_add(struct ionic_lif *lif,
        }
 
        if (err != -ENOSPC)
-               err = ionic_adminq_post_wait(lif, &ctx);
+               err = ionic_adminq_post_wait_nomsg(lif, &ctx);
 
        spin_lock_bh(&lif->rx_filters.lock);
 
@@ -382,6 +382,19 @@ static int ionic_lif_filter_add(struct ionic_lif *lif,
                        return 0;
                }
 
+               ionic_adminq_netdev_err_print(lif, ctx.cmd.cmd.opcode,
+                                             ctx.comp.comp.status, err);
+               switch (le16_to_cpu(ctx.cmd.rx_filter_add.match)) {
+               case IONIC_RX_FILTER_MATCH_VLAN:
+                       netdev_info(lif->netdev, "rx_filter add failed: VLAN %d\n",
+                                   ctx.cmd.rx_filter_add.vlan.vlan);
+                       break;
+               case IONIC_RX_FILTER_MATCH_MAC:
+                       netdev_info(lif->netdev, "rx_filter add failed: ADDR %pM\n",
+                                   ctx.cmd.rx_filter_add.mac.addr);
+                       break;
+               }
+
                return err;
        }